Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facade alias would cause duplicate imports for global aliases #4

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Facade alias would cause duplicate imports for global aliases #4

merged 3 commits into from
Sep 21, 2023

Conversation

matt-h
Copy link
Contributor

@matt-h matt-h commented Sep 21, 2023

  • 5440708 Failing test that show that imports are duplicated if there is more than one of the same global class
  • 46a2832 fix str_contains parameter order to fix duplicate imports
  • f389331 add additional test for duplicate normal items for better coverage to prove that still works.

@jasonmccreary
Copy link
Collaborator

First PR!

Seems I need to set the pull_request event for the tests to run, but I'll get that fixed separately.

@jasonmccreary jasonmccreary merged commit c77d7af into laravel-shift:main Sep 21, 2023
@matt-h
Copy link
Contributor Author

matt-h commented Sep 21, 2023

I'm glad to be the first PR! I'm liking the tool and I enjoyed all of the YouTube and Laracasts streams watching you build it.

@jasonmccreary
Copy link
Collaborator

Awesome. I'll get this tagged later today.

@BrandonSurowiec BrandonSurowiec mentioned this pull request Sep 23, 2023
Closed
@jasonmccreary jasonmccreary mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-h @jasonmccreary